Difference between revisions of "AOSP Contribution"
Line 7: | Line 7: | ||
this is WRONG | this is WRONG | ||
dso : NULL, | dso : NULL, | ||
− | reserved : {0} | + | reserved : {0} |
this is CORRECT | this is CORRECT |
Revision as of 02:22, 15 February 2015
Following are some of the lessons I learned submitting patches to AOSP:
1) Android standard, headers first grouped by system, library, then local. All headers in alphabetical order in each group.
2) Use the proper notation for class
this is WRONG
dso : NULL, reserved : {0}
this is CORRECT
.version_major = 1, .version_minor = 0,
3) For every patch there are 2 state - review and verified state
(*) You need +2 for Review state (*) You need +1 for Verify state(typically the owner) for integration and testing to confirm the changes works fine.
4) Look around in the project that you are working on who are the people that contribute the most and assign them to your gerrit issue. Assign at least 3-4 Google developers that are working on the project as your reviewer, this will give you the confidence that your code has been viewed from different perspective.
Patches that I've submitted to Google AOSP (Android Open Source Projects) can be viewed from this link.